Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhance] Support visualization of multi-modality 3D detector using multi-view images #2488

Merged
merged 8 commits into from
May 10, 2023

Conversation

JingweiZhang12
Copy link
Contributor

@JingweiZhang12 JingweiZhang12 commented Apr 28, 2023

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the back-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@JingweiZhang12 JingweiZhang12 requested a review from ZCMax May 4, 2023 09:17
@codecov
Copy link

codecov bot commented May 4, 2023

Codecov Report

Patch coverage: 11.42% and project coverage change: -0.13 ⚠️

Comparison is base (864ed34) 47.12% compared to head (3e04262) 47.00%.

❗ Current head 3e04262 differs from pull request most recent head 9fd128b. Consider uploading reports for the commit 9fd128b to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           dev-1.x    #2488      +/-   ##
===========================================
- Coverage    47.12%   47.00%   -0.13%     
===========================================
  Files          276      276              
  Lines        23011    23079      +68     
  Branches      3582     3602      +20     
===========================================
+ Hits         10845    10849       +4     
- Misses       11484    11544      +60     
- Partials       682      686       +4     
Flag Coverage Δ
unittests 47.00% <11.42%> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmdet3d/apis/inference.py 13.63% <0.00%> (-0.83%) ⬇️
mmdet3d/engine/hooks/visualization_hook.py 49.47% <11.11%> (-8.56%) ⬇️
mmdet3d/visualization/local_visualizer.py 30.32% <15.38%> (-3.13%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@sunjiahao1999 sunjiahao1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@JingweiZhang12 JingweiZhang12 merged commit 35fd839 into open-mmlab:dev-1.x May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants